Closed FuzzyNovaGoblin closed 8 months ago
its not letting me comment on it but @Redempt said
Since this is such a large changeset, could you try to summarize some of what you did? Some things in here seem unrelated to fender strings.
Can you give an example? I went through quickly and didn't see anything that wasn't just updating stuff to work with the new strings or the creation of the new strings themselves. I did see a macro for writing the out of bounds errors because there was just a lot of duplication and wanted to make sure they were all the same, but even that was because I was adjusting methods for the new strings.
Okay, I left that comment a while ago so I don't know what I was talking about specifically anymore.
this change is not done yet it still needs to have some methods implemented for strings that were previously only implemented for lists, and there are a number of times where
toString
is called to use the rust std string functions but these methods can be implemented for theFenderString
to eliminate thosetoString
calls