search

Feodor2 / Mypal68

web browser
Other
608 stars 37 forks source link

Better dark mode #399

Closed K4sum1 closed 3 months ago

K4sum1 commented 6 months ago

Enabling dark mode should also enable the code that displays a dark mode version of the page. An example of this is it should recognize the CSS @media (prefers-color-scheme: dark) if the dark theme is enabled and use it. There are also some websites that do this in JS instead, but I have no idea what all that entails. This CSS code was added to Firefox 67, so it is there. Just this early on it reflected the system settings and not the browser theme. Considering 10 1709 and 8.1 and earlier don't have a proper dark mode, this always defaults to light mode.

Also making the settings page dark like in current Firefox would be cool too. ScreenShot_20240316035512

K4sum1 commented 6 months ago

So this should be able to be fixed by a GUI option to set browser.in-content.dark-mode to true, and ui.systemUsesDarkTheme to 1. Although I needed to restart browser for it to take effect.

MyPal even already has dark mode settings with these both set. ScreenShot_20240317062415

Feodor2 commented 6 months ago

I shall look to set them default