search

FeraeLabs / skunk

A person-in-the-middle proxy
MIT License
0 stars 0 forks source link

Improper handling of connection shutdown #8

Closed jgraef closed 5 months ago

jgraef commented 5 months ago

After a HTTP request was successfully proxied through skunk, I get this log message:

2024-05-13T21:21:27.823155Z  WARN socks{address=127.0.0.1:59384}: tracing_unwrap: called `Result::ok_or_log` on an `Err` value: Io(Os { code: 107, kind: NotConnected, message: "Transport endpoint is not connected" })

I think hyper shuts down the stream and socks still wants to use it.

jgraef commented 5 months ago

The source stream from the socks server implementation is shutdown, so there's nothing we can do about it. It is fine to ignore errors that occur on shutdown.