Open elfring opened 5 years ago
It'll be worth giving the code a once over to make sure we're checking return values when it's appropriate and graceful recovery is possible.
Realistically, with the examples you've given, there's not much we can do except "exit immediately" if those particular functions return errors.
How do you think about to improve static source code analysis also for this software?
https://www.github.com/FeralInteractive/gamemode/tree/master/scripts%2Fstatic-analyser-check.sh already has static analysis implemented
Does a combination of analysis tools point any remaining open issues out?
I ran this check just now and got nothing but false positives. A few instances of "Called function pointer is null (null dereference)".
These all came from the fact that the analyzer assumes that internal_load_libgamemode()
will return successfully but it doesn't take into account that the only way it can return successfully is if its managed to set global function pointers.
Would you like to add more error handling for return values from functions like the following?