search

FergalMoriarty / first-docker

Uses python tin a docker container to connect to redshift dev
0 stars 1 forks source link

No need to update a Docker container #2

Open gparrello opened 2 years ago

gparrello commented 2 years ago

https://github.com/FergalMoriarty/first-docker/blob/3852ec75c60f790a0ccff4bc01cedbf0e470eaa9/Dockerfile#L6

One of the points of having a container is its immutability: the contained infrastructure is fixed and expected; if you run an update then the image depends on what is being updated at each point in time, and this varies.

It is much better to update the base images themselves, read this for more info: https://stackoverflow.com/questions/63892211/do-i-need-apt-get-update-and-upgrade-in-my-python-dockerfile

ahmadjubair33 commented 2 years ago

Hi @FergalMoriarty assign this issue to me I will update the Dockerfile. thankyou....

ahmadjubair33 commented 2 years ago

Hi, @FergalMoriarty I have raised a PR for this issue please review and merge it. Thank You...