Ferk / udev-media-automount

A simple automount mechanism using udev rules
Other
125 stars 59 forks source link

service file assumes $DESTDIR=="/usr" #21

Open patrislav1 opened 8 months ago

patrislav1 commented 8 months ago

in media-automount@.service there's a hardcoded reference to /usr/bin/media-automount.

Makefile however installs the script to $(DESTDIR)$(PREFIX)/bin/media-automount.

On my system, both DESTDIR and PREFIX are empty, so the script is never called.

Suggestion: either leave away the $(DESTDIR)$(PREFIX) in the Makefile and hard code the prefix to /usr, or configure the service file at build time.

I would do a PR however am not that seasoned in Makefile builds, what's the best practice to achieve this? maybe insert something like @DESTDIR@ in the service file and replace it with sed?