Ferlab-Ste-Justine / Post-processing-Pipeline

Variant analysis for genome and exome VGCFs
Apache License 2.0
0 stars 0 forks source link

feat: CLIN-3090 Save logs and move initialization logic to PIPELINE_INITIALISATION #12

Closed LysianeBouchard closed 2 months ago

LysianeBouchard commented 3 months ago

Warning: THIS IS A DRAFT, NOT READY FOR REVIEW THIS PR IS TOO BIG, I WILL SPLIT IT.

Changes:

Note: The copied log file is not entirely complete. It will miss a few logs from the completion handler and other Nextflow internal handlers (e.g., reports). However, the missing logs should not contain any critical information for debugging.

Tests description

I run the linter and double check that there is no new warning in comparison to the main branch. Actually we have 39 warnings instead of 41 because. I fixed 3 TODO comments warnings and there is one new warning because there is a new version available for one of the nf-core module that we are using. nf-core lint

╭───────────────────────╮
│ LINT RESULTS SUMMARY  │
├───────────────────────┤
│ [✔] 159 Tests Passed  │
│ [?]  37 Tests Ignored │
│ [!]  39 Test Warnings │
│ [✗]   0 Tests Failed  │
╰───────────────────────╯

I run the pipeline locally in stub mode. It completed successfully in all these cases:

nextflow run main.nf -stub -profile test
nextflow run main.nf -stub -profile test,docker 
nextflow -log "foo.log"  run main.nf  -stub-run -profile test,docker
nextflow -log "foo bar.log"  run main.nf  -stub-run -profile test,docker

I verified that the nextflow log file was correctly copied to ./results/pipeline_info/nextflow.log in all cases.

Extra tests needed:

PR checklist

LysianeBouchard commented 2 months ago

Closing pull request as it is already addressed through other PRs.