Fermain / -mollify

9 stars 9 forks source link

Created audio not shown? #130

Closed mitthrawnuruodo closed 11 months ago

mitthrawnuruodo commented 11 months ago

When using Create Audio (or Regenerate Audio File), I get a success massage, but the audiobar isn't changed and I cannot play audio?

Fermain commented 11 months ago

Relates to #129, it's a bug

MegumiKim commented 11 months ago

@Fermain @ShaindalDev I'm working on the issue related to AudioBar and I'd like to see the actual response from API. Could you send me ELEVENLABS_API_KEY?

Fermain commented 11 months ago

Yep, will post it now on Discord

@Fermain @ShaindalDev I'm working on the issue related to AudioBar and I'd like to see the actual response from API. Could you send me ELEVENLABS_API_KEY?

MegumiKim commented 11 months ago

I have identified the bug and created a PR, please review.

MegumiKim commented 11 months ago

One note: In the current design, Reader component should belong to Footer, not Header. Can I move it?

Fermain commented 11 months ago

Ideally the Reader component lives inside the TTS package and is imported by LMS - I agree that it is not in the right folder, but it doesn't need to be linked to header/footer at all.

Fermain commented 11 months ago

I have tested this and confirmed that it's working. I suggest unhiding the Reader component, changing it's folder location to components/Reader and finish this PR.

You can raise another issue to migrate the component into the TTS package.

MegumiKim commented 11 months ago

Done!