Fermain / -mollify

9 stars 9 forks source link

Reader component location #146

Open MegumiKim opened 11 months ago

MegumiKim commented 11 months ago

Currently Reader component lives inside the LMS package, but it should live inside the TTS package and be imported by LMS.

Anclagen commented 11 months ago

I think the component should be further abstracted to allow for separation of concerns.

In a previous issue #60 we also discussed the TTS being installed on its own server to manage creation, storage, and serving of the files so the reader component itself would simply be requesting a specific lessons file from here.

Fermain commented 11 months ago

I have that magic server, so we can do free TTS with slightly below Elevenlabs quality.

Molly exports one component and an HTTP method - I like that pattern as it makes it easy to intergrate into any Sveltekit project. I think LMS should have theme control over the reader, but I'm ok with it being abstracted away as well.

Fermain commented 9 months ago

To complete, migrate the Reader component to TTS repo as an importable component