search

Fermain / -mollify

9 stars 9 forks source link

A simple Improvement to right side nav #153

Closed Lysaker-git closed 10 months ago

Lysaker-git commented 11 months ago

Added variable parent to check if parent element, added icon on parent element and added more padding to child elements

Was messing a lot with how to solve it in a small and effective way. I believe this will be a simple quality of life improvement to the right side lesson nav.

Lysaker-git commented 10 months ago

Converted to draft to await approved PR in same file in other PR's

Lysaker-git commented 10 months ago

Changes made after cooperation with how it was set up by @Ousman37

Pulled Entity into it's own file that way the open and close toggle could stay how it was. Drew inn DrawerStore and used the .close() to close the nav once a tag is clicked Added conditional to the parent variable to get icon on all parent elements.

Now connected to PR 156

Lysaker-git commented 10 months ago

Please note that how we pull in the icons might have to change when #162 is pushed into main. logic should be able to stay the same.

pretzL commented 10 months ago

Resolve the merge conflict and update formatting, please.

Lysaker-git commented 10 months ago

Resolve the merge conflict and update formatting, please.

Hopefully that everything looks good now. Did npm run format as well.