Fermain / -mollify

9 stars 9 forks source link

active mode nav + open active tab on mount #177

Closed StianSto closed 9 months ago

StianSto commented 9 months ago

Added a feature to highlight the current document. for now it matches the exact path. I chose a pretty random color. im sure we'll come back to a design revamp sooner or later anyway :) this resolves #109

Fermain commented 9 months ago

I'm not seeing any highlights - am I missing something?

Edit: I am seeing a highlight on the Course name, not the lesson name - is this intentional?

image
Melisa-Zorraindo commented 9 months ago

I saw the lesson highlighted, not the course, when I tried it yesterday

Fermain commented 9 months ago

It's an issue with onMount - you have to refresh to re-render the component

Melisa-Zorraindo commented 9 months ago

Where there any changes made after I approved? I didn't have to refresh to see the active link

Fermain commented 9 months ago

Where there any changes made after I approved? I didn't have to refresh to see the active link

Nope, pretty sure I tested the same thing as you

Melisa-Zorraindo commented 9 months ago

Maybe I was clicking on the exact same lesson every time I was trying to find a way to get the theme variables to work, sorry

pretzL commented 9 months ago

I'm seeing the same as Melisa. I don't have to do anything extra to see the course highlighted like reloading the component.

Fermain commented 9 months ago

You aren't allowed to gang up on me

pretzL commented 9 months ago

You aren't allowed to gang up on me

Consider yourself ganged up on

Fermain commented 9 months ago

Consider yourself ganged up on

gung upon

pretzL commented 9 months ago

Consider yourself ganged up on

gung upon

gungst've

Fermain commented 9 months ago

I tested again with a full rebuild and I have the same behaviour

pretzL commented 9 months ago

Can confirm it seems like a desktop vs mobile issue. Mobile works fine, desktop does not.