Fermain / -mollify

10 stars 9 forks source link

Feature: Molly-chat Improvements #81

Closed Jenfer93 closed 1 year ago

Jenfer93 commented 1 year ago

Molly improvements to be considered:

MegumiKim commented 1 year ago

@ShaindalDev @Jenfer93 @Fermain

Molly frontend tasks I am working on can be divided to several stages. I would like to request reviews/merge at each sub tasks I am working on.

MegumiKim commented 1 year ago

@Jenfer93 I don't quite understand "Implement a img on user and molly chat message". Could you please elaborate?

MegumiKim commented 1 year ago

@ShaindalDev @Fermain @Jenfer93

I would like to reconfirm with others if we really want full window screen or full height with half screen or some other options for chat screen size option. Also, what will be the good height ratio for textarea and Molly's response.

This might be also reflected in the new prototype?

Anclagen commented 1 year ago

@Jenfer93 I don't quite understand "Implement a img on user and molly chat message". Could you please elaborate?

I assume this would refer to adding a users avatar next to their text in the molly chat, similar to discord.

Anclagen commented 1 year ago

@ShaindalDev @Fermain @Jenfer93

I would like to reconfirm with others if we really want full window screen or full height with half screen or some other options for chat screen size option. Also, what will be the good height ratio for textarea and Molly's response.

This might be also reflected in the new prototype?

If its not a hassle to implement could I suggest having a text area that grows to about third or half the view port height depending on how much content the users puts in.

I think on phones/tablets having it full screen would be best, maybe intermediate sizes we could have the options to squash to the side over the navs or go full screen. I wouldn't mind on larger screens at least having the option to have molly chat take up all the space on the right hand side, covering the nav and table of contents.

MegumiKim commented 1 year ago

@Fermain @ShaindalDev I would like to continue working on the sanitisation of user input, so I re-opened the issue :-)

MegumiKim commented 1 year ago

It seems there is defence on the server side but user text input is still vulnerable. Seems like most effective way is to use DOMPurify (https://www.npmjs.com/package/dompurify). Is it ok to install it in Molly package?

MegumiKim commented 1 year ago

Molly's icon is added to Molly's response. For user side, user's avatar shall be added in future when that feature is implemented.

MegumiKim commented 1 year ago

I was not able to resolve "Molly's code break" issue during this sprint as this was not quite frontend fixes. I will create a separate issue for future sprints.