FermiQC / Fermi.jl

Fermi quantum chemistry program
MIT License
135 stars 24 forks source link

Mysterious parameter in the RHF code #41

Closed gustavojra closed 3 years ago

gustavojra commented 4 years ago
function RHF(molecule::Molecule, aoint::IntegralHelper, C::Array{Float64,2}, Λ, Alg::ConventionalRHF)
    @output "Computing integrals ..."
    t = @elapsed aoint["μ"]
    @output " done in {:>5.2f} s\n" t
    RHF(molecule,aoint,C,aoint["μ"],Λ)
end
function RHF(molecule::Molecule, aoint::IntegralHelper, C::Array{Float64,2}, Λ, Alg::DFRHF)
    @output "Computing integrals ..."
    t = @elapsed aoint["B"]
    @output " done in {:>5.2f} s\n" t
    RHF(molecule,aoint,C,aoint["B"],Λ)
end

This Λ needs some specification, right now this method will accept anything for Λ. Also some clarification on what is that via docs or comment would be nice.

mdav2 commented 4 years ago

Okay yeah. It's the orthogonalizer, which I moved out of the RHF kernel so we could choose symmetric vs. canonical orthogonalization.

mdav2 commented 4 years ago

I think we should just always use canonical though, its more stable for near-linearly dependent cases.

gustavojra commented 3 years ago

Solved with refactorization