FermiQC / Molecules.jl

Library that handles atom structures as XYZ files and properties derived from it.
MIT License
13 stars 10 forks source link

Merging Symmetry.jl and Molecules.jl #12

Closed sgoodlett closed 2 years ago

sgoodlett commented 2 years ago

Symmetry.jl has been where most of the development for symmetry element and character table generation has taken place. We are moving this functionality to Molecules.Symmetry.CharacterTables.

This adds a few new features.

Future Work:

codecov[bot] commented 2 years ago

Codecov Report

Merging #12 (b3d5ef1) into main (8976b12) will decrease coverage by 17.64%. The diff coverage is 52.33%.

@@             Coverage Diff             @@
##             main      #12       +/-   ##
===========================================
- Coverage   86.18%   68.53%   -17.65%     
===========================================
  Files          10       16        +6     
  Lines         637     1319      +682     
===========================================
+ Hits          549      904      +355     
- Misses         88      415      +327     
Impacted Files Coverage Δ
src/Molecules.jl 100.00% <ø> (ø)
...rc/Symmetry/CharacterTables/MultiplicationTable.jl 0.00% <0.00%> (ø)
src/Symmetry/flowchart.jl 86.07% <ø> (ø)
src/Symmetry/moit.jl 100.00% <ø> (ø)
src/Symmetry/sea.jl 98.00% <ø> (ø)
...c/Symmetry/CharacterTables/PointGroupGenerators.jl 24.08% <24.08%> (ø)
src/Symmetry/CharacterTables/Main.jl 70.22% <70.22%> (ø)
src/Symmetry/CharacterTables/Basics.jl 83.33% <83.33%> (ø)
...mmetry/CharacterTables/CharacterTableGenerators.jl 88.23% <88.23%> (ø)
src/Symmetry/CharacterTables/CharacterTables.jl 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8976b12...b3d5ef1. Read the comment docs.

gustavojra commented 2 years ago

Holding gods hand and merging