Fermium / datalogger

The Datalogger physicists deserve
0 stars 0 forks source link

Misalignments and incomplete UI in the device select page #57

Closed ddavidebor closed 7 years ago

ddavidebor commented 7 years ago

The UI in the "device select" page is not complete.

Here are some things that should be fixed:

To test, please note the device text and proprierties are (and must be) automatically populated from the app/devices/ folder.

ghost commented 7 years ago

Does this issue still exist: "The Window should have the same top bar as the main window. Of course not the controls, that differ, but at least logo and top bar."

ghost commented 7 years ago

My interpretations/queries:

  1. Regarding this issue: "add a small logo for the manufacturer. Maybe greyed out. This needs to be added to the device configuration file in the app/devices/ folder too (as it changes from device to device)" => Need assets for the logo. Do we have them ready?

  2. Regarding issue: "pictures are not resizing correctly, needs to be fixed" => Images does not scale as per device width and height?

ddavidebor commented 7 years ago

Does this issue still exist: "The Window should have the same top bar as the main window. Of course not the controls, that differ, but at least logo and top bar."

yes. In the main window we have a blue bar on the top with logo and buttons. We should re-use that, similarly, in the select-device window. Just instead of the four button on the right maybe the search field.

This way it will look more consistent.

Regarding this issue: "add a small logo for the manufacturer. Maybe greyed out. This needs to be added to the device configuration file in the app/devices/ folder too (as it changes from device to device)"

What about it ?

ddavidebor commented 7 years ago

Oh for logo in the top bar i mean our logo #44 (currently "limitless" from the theme), for manufacturer logo i mean a logo of the device manufacturer in each and every device (content of the select-device page)

ghost commented 7 years ago

Please share on below one too.

Regarding issue: "pictures are not resizing correctly, needs to be fixed" => Images does not scale as per device width and height?

ddavidebor commented 7 years ago

MMh. I don't remember where I saw that... Maybe has been fixed already or i dreamed it

ddavidebor commented 7 years ago

I deleted it. If it exist is gonna came up again sooner or later

wtubog commented 7 years ago

@ddavidebor for the search feature, the current code is only searching for product and product-producer only and not searching for product name. Is this the right behavior? If no, let's open another issue for this :dagger:

ddavidebor commented 7 years ago

@wtubog no it's not, good catch. Issue here https://github.com/ddavidebor/datalogger/issues/74

ddavidebor commented 7 years ago

add a small logo for the manufacturer. Maybe greyed out. This needs to be added to the device configuration file in the app/devices/ folder too (as it changes from device to device)

@wtubog in the current proposal in #73 the logo placeholder is too small. We should either find a different place or remove this requirement

wtubog commented 7 years ago

Modified and tested search code..

wtubog commented 7 years ago

@ddavidebor I am no design expert XD what is the size of the logo anyways?

Closing this for now