search

Fermium / datalogger

The Datalogger physicists deserve
0 stars 0 forks source link

confirm action error #61

Closed ddavidebor closed 7 years ago

ddavidebor commented 7 years ago

If an error is catched by the confirm action in the mathsheet editor, the window closes nontheless.

A better error reporting should be implemented, that catches and reports more cases.

mathsheet_confirm

ghost commented 7 years ago

My interpretations/queries:

  1. Do we need to display error in proper format?
  2. In javascript when error occurs at one place then it stops execution further in that file. Hence catch all error at once is not possible.
ddavidebor commented 7 years ago
  1. yes, that windows that pops up in the middle of the screen telling you you inputted something wrong is very annoying. Maybe have a red text appear and disappear above the confirm button? Or better, one of the pretty notifications we used in the app.
  2. ok you're right

Important problem that should be fixed: the window should not close due to the error. An error should pop up if the user tries to confirm an invalid mathsheet, but he needs to be able to fix it and then confirm again.

wtubog commented 7 years ago

Done, used bootstrap's alert panel. Please check if error / success message is okay @ddavidebor

ddavidebor commented 7 years ago

From the code seems fine but I've realized I can't trigger an error for some reason.

Strange, I'm discussing the issue with @SimoneTosato, it was before your commits

ddavidebor commented 7 years ago

I need the USB to test this. I will change the error message to reflect this to

wtubog commented 7 years ago

The mathsheet will produce an error if some of the equations is incorrect

ex.

I = (ch3 * 7 ) V / (4 ohm)

you changed to (notice the missing parenthesis):

I = (ch3 * 7 V / (4 ohm)

errors will come from Mathjax because it couldn't properly render the equation

ddavidebor commented 7 years ago

Yes but apparently works only if USB is enabled

On ven 25 ago 2017, 08:00 Wilco Tubog notifications@github.com wrote:

The mathsheet will produce an error if some of the equations is incorrect

ex.

I = (ch3 * 7 ) V / (4 ohm)

you changed to (notice the missing parenthesis):

I = (ch3 * 7 V / (4 ohm)

errors will come from Mathjax because it could to properly render the equation

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ddavidebor/datalogger/issues/61#issuecomment-324831107, or mute the thread https://github.com/notifications/unsubscribe-auth/AIot_mqXrS9tSc03MPMn0O8Zm5d65e2Oks5sbmMSgaJpZM4O3Wj7 .

wtubog commented 7 years ago

Weird. I'm able to replicate the errors on my mac..

ddavidebor commented 7 years ago

Ok syntax errors work, mispelled variables (=variable not found) do not work. That's acceptable