Fermium / datalogger

The Datalogger physicists deserve
0 stars 0 forks source link

Gain Styling #62

Closed ddavidebor closed 7 years ago

ddavidebor commented 7 years ago

The Gain page should be improved:

I suggest formatting it an a table like this:

Variable Gain Description
ch1 [dropdown menu here] blablablabla
ch2 [dropdown menu here] blablablabla
ch3 [dropdown menu here] blablablabla

The titles do not need to be written, they're pretty obvious.

gain_styling

ghost commented 7 years ago

My interpretations/queries:

I could not find config.yml in the git repo from develop branch but I can see drone.yml which have channel name. Is it the same and that we want to use along with mathsheet variable name? e.g. ProjectHallFlux1, ProjectHallFlux2 and so on.

ddavidebor commented 7 years ago

@rutpshah here it is https://github.com/ddavidebor/datalogger/blob/develop/app/devices/labtrek/ltk-hall/config.yaml

wtubog commented 7 years ago

@ddavidebor channel names inside the config yaml is ch1, ch2 and so on.. Do we need to modify the config yaml to with the proper name of the channel like the ones on your example above?

ddavidebor commented 7 years ago

Woops my error. no problem, the current names are fine. i've edited the example table in the first post.

Also: If it's fine for formatting, we can keep the current name + description approach. If the descriptions are too long, we could use current name + description + long description.

wtubog commented 7 years ago

Done. Used bootstrap tables for this.

@ddavidebor what do you mean by long description? is this different to the ones at the config with the name "description"?

ddavidebor commented 7 years ago

i was thinking of making the current description the long one, and adding a shorter one

wtubog commented 7 years ago

Okay, just notify me if add a long description and I'll modify the layout..

wtubog commented 7 years ago

closing this for now