Fermium / hall-effect-handbook

Public docs about the Hall effect instrument
Other
0 stars 0 forks source link

joint companies footer #4

Closed ddavidebor closed 8 years ago

ddavidebor commented 8 years ago

This is a good example of a pull request.

I've made the modifications in the footer in the develop branch and pushed it.

I can tag users: @torzog

ddavidebor commented 8 years ago

As you can see since there are no conflicts, the system merge them and test them, but it does not make public changes outside this pull requests.

in a few minutes @torzog the checks should be passed, then i can accept the pull request.

ddavidebor commented 8 years ago

The pull requests is not between single commits, but it's between branches. In this way if there is any problem you can just solve it and push (sync). All the checks will be done a second time, and we can repeat the process until everything is fine and the pull requests can be merged.

ddavidebor commented 8 years ago

@torzog all checks are passed!

ddavidebor commented 8 years ago

oh i forgot: the result of the pull request can be analyzed. The system generates a link like this https://transfer.sh/V2lgL/hall-handbook.zip which give access for 2 weeks to the resulting files.

I'm trying to get the system to show the link without having to search it manually.