FernetMenta / vdr-plugin-vnsiserver

VDR plugin to handle XBMC clients.
GNU General Public License v2.0
16 stars 33 forks source link

compile error after commit fa3b997 for vdr-2.2.0 #59

Closed Karl-opec closed 8 years ago

Karl-opec commented 8 years ago

compiling latest git tree leads to unkwown cStateKey timerState;

commenting line 253 in vnsitimer.c out, everything compiles and runs.

FernetMenta commented 8 years ago

fixed, thanks

Karl-opec commented 8 years ago

Moving [code] void CVNSITimers::Action() { bool modified;

if VDRVERSNUM >= 20301

[/code]

if VDRVERSNUM >= 20301 above bool modified; fixes a compile warning for 2.2.0

FernetMenta commented 8 years ago

could you submit a pull request or at least a patch?

Karl-opec commented 8 years ago

Here is the patch: comp-wan.txt

FernetMenta commented 8 years ago

thanks, btw github markup for code snippets is 3 times this character "`" before and after the code.

this is code
Karl-opec commented 8 years ago

Thanks for the hint

Karl-opec commented 8 years ago
g++ -g -O3 -Wall -march=core-avx2 -mavx2 -Woverloaded-virtual -Wno-parentheses -fPIC -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -std=c++11 -c -D_GNU_SOURCE -DPLUGIN_NAME_I18N='"vnsiserver"' -DVNSI_SERVER_VERSION='"1.5.0"' -I/usr/src/packages/BUILD/vdr-2.2.0/include -o vnsitimer.o vnsitimer.c
vnsitimer.c: In member function ‘virtual void CVNSITimers::Action()’:
vnsitimer.c:255:8: warning: unused variable ‘modified’ [-Wunused-variable]
   bool modified;
        ^

Please commit the following fix for the above compile warning with vdr-2.2.0:

--- vnsitimer.c.orig    2016-07-06 10:30:09.837216870 +0200
+++ vnsitimer.c 2016-07-06 10:42:12.601092046 +0200
@@ -252,9 +252,8 @@ bool CVNSITimers::IsDuplicateEvent(cTime

 void CVNSITimers::Action()
 {
-  bool modified;
-
 #if VDRVERSNUM >= 20301
+  bool modified;
   cStateKey timerState;

   // set thread priority (nice level)
FernetMenta commented 8 years ago

done