Google recaptcha is now defaulted to the site's l10n

FernleafSystems / Shield-Security-for-WordPress

Reflection of the Shield plugin on WordPress.org

https://getshieldsecurity.com

9 stars 4 forks source link

Google recaptcha is now defaulted to the site's l10n #23

Closed AubreyHewes closed 8 years ago

AubreyHewes commented 8 years ago

Force site's l10n on recaptcha..

For example a X site now has the recaptcha in X irrelevant of the used browser locale Y..

e.g. Spanish site (es) has spanish recaptcha (not browser locale; en) so fits the spanish login...

Todo is a possible option to disable forced l10n..

paulgoodchild commented 8 years ago

If I understand this correctly, I'm not sure if this is the behaviour I want. If an English-speaking user visits a Russian site to login, for whatever reason, if they don't understand Russian, they may not fully appreciate the login fields. Ideally a login page would reflect, wherever possible, the language of the user browsing to that page?

Am I understanding this correctly?

AubreyHewes commented 8 years ago

A wp site can have a locale (language)... the login page is based on the locale; all fields are in the wp site locale (so already translated). The same (call it a wp-locale) should be used for the recaptcha.. This change ensures the recaptcha is at least as close to the given wp-locale as possible.

i.e. a ru locale site accessed by an en browser already has ru login texts and so should also have a ru recaptcha. An en recaptcha makes no sense. The site defines the l10n, not the browser.

paulgoodchild commented 8 years ago

I've tweaked and merged this. It'll be in the next release. Cheers!

AubreyHewes commented 8 years ago

cool :+1: