search

Ferry-200 / coriander_player

Windows端本地音乐播放器，使用Material You配色。Dart (Flutter) + Rust (lofty, windows-rs) + C (bass lib) 多语言项目。绝赞开发中。
https://ferry-200.github.io/coriander_player_website/
GNU General Public License v3.0
510 stars 22 forks source link

fix some structures of rust code #61

Closed chanmaoganda closed 1 month ago

chanmaoganda commented 1 month ago

replace &Path to impl AsRef remove unnecessary wrapping of a Enum value fix non-sense comparisons

chanmaoganda commented 1 month ago

我再看一下还有没有能优化的部分

Ferry-200 commented 1 month ago

好快！吃完饭我就编译并验证一下

chanmaoganda commented 1 month ago

tag

Ferry-200 commented 1 month ago

btw, what makes u write the rust code of tag_reader: line 570(if let None = version ) ? (doge)

谁知道为什么（ 不过这倒是正常工作的

Ferry-200 commented 1 month ago

初步验证没有发现问题

chanmaoganda commented 1 month ago

这块 l535-l542的设计思路是只需要用json对吧, 为什么不定义可序列化的struct? 直接derive(Serialize)

Ferry-200 commented 1 month ago

这块 l535-l542的设计思路是只需要用json对吧, 为什么不定义可序列化的struct? 直接derive(Serialize)

因为我不知道😂

不过就先这样吧，这部分先不改

chanmaoganda commented 1 month ago

那就合并吧, 到时候要是有什么需要改的再提pr