Closed 255doesnotexist closed 6 months ago
$KSU && MOUNTPATH=$(dirname $MODPATH) || MOUNTPATH="$(magisk --path)/.magisk/modules"
will accidentally change MOUNTPATH if $KSU = false.
$KSU = false make the whole expression '$KSU && MOUNTPATH=$(dirname $MODPATH)' = false.
then shell will execute 'MOUNTPATH="$(magisk --path)/.magisk/modules" '
that is accidentally changed Magisk users' MOUNTPATH
so add the "$KSU &&" after the "||" is absolutely patch to reach maintainers original meanings
(as the "&&"'s priority higher than "||")
not work on other devices. i should take it back and think twice.
will accidentally change MOUNTPATH if $KSU = false.
$KSU = false make the whole expression '$KSU && MOUNTPATH=$(dirname $MODPATH)' = false.
then shell will execute 'MOUNTPATH="$(magisk --path)/.magisk/modules" '
that is accidentally changed Magisk users' MOUNTPATH
so add the "$KSU &&" after the "||" is absolutely patch to reach maintainers original meanings
(as the "&&"'s priority higher than "||")