FertigLab / scatterHatch

Other
7 stars 3 forks source link

This got me very excited! #12

Open ellispatrick opened 1 year ago

ellispatrick commented 1 year ago

Hi Atul,

I have a hatching function in my package lisaClust which is super slow! I just got very excited when I saw this package.

Is there a way to make the colour of the points (maybe cell types) different to the hatching (some sort of region) with scatterHatch so that I can generate plots like the ones at the bottom of https://www.biorxiv.org/content/biorxiv/early/2022/04/19/2022.04.19.488697/F5.large.jpg?width=800&height=600&carousel=1

Or is there an equivalent to the geom_hatching() in lisaClust?

Also, have you had any thoughts in extending this past 7 hatching patterns?

Thanks, Ellis

atuldeshpande commented 1 year ago

Hi Ellis,

If I understand correctly, you want to use different annotations for the cell type (color) and the tissue region (hatching). Unfortunately, as it stands, scatterHatch doesn't do that. I think this would be a cool feature to have for future use cases and could be easily implementable (although it would be detrimental to the accessibility of the visualizations).

We allow users to create their own hatching patterns but they are all based on straight lines (reason being we wanted to be able to also draw them on individual sparse points). So you can create new hatching patterns using line types, line colors or different line angles if needed, but only lines.

Have you considered the ggpattern package? It allows hatching type patterns to be plotted on polygons, which could be applied to your case with some finessing.

Atul

On Fri, Aug 4, 2023 at 3:12 PM Ellis Patrick @.***> wrote:

Hi Atul,

I have a hatching function in my package lisaClust which is super slow! I just got very excited when I saw this package.

Is there a way to make the colour of the points (maybe cell types) different to the hatching (some sort of region) with scatterHatch so that I can generate plots like the ones at the bottom of https://www.biorxiv.org/content/biorxiv/early/2022/04/19/2022.04.19.488697/F5.large.jpg?width=800&height=600&carousel=1

Or is there an equivalent to the geom_hatching() in lisaClust?

Also, have you had any thoughts in extending this past 7 hatching patterns?

Thanks, Ellis

— Reply to this email directly, view it on GitHub https://github.com/FertigLab/scatterHatch/issues/12, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDSCIK25UZF44TUNO7X5Y3XTVCRXANCNFSM6AAAAAA3ES46PI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

ellispatrick commented 1 year ago

Thanks for the fast response. I'll check out ggpattern.

Say hi to Elana for me :)

Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: atuldeshpande @.> Sent: Friday, August 4, 2023 3:36:39 pm To: FertigLab/scatterHatch @.> Cc: Ellis Patrick @.>; Author @.> Subject: Re: [FertigLab/scatterHatch] This got me very excited! (Issue #12)

Hi Ellis,

If I understand correctly, you want to use different annotations for the cell type (color) and the tissue region (hatching). Unfortunately, as it stands, scatterHatch doesn't do that. I think this would be a cool feature to have for future use cases and could be easily implementable (although it would be detrimental to the accessibility of the visualizations).

We allow users to create their own hatching patterns but they are all based on straight lines (reason being we wanted to be able to also draw them on individual sparse points). So you can create new hatching patterns using line types, line colors or different line angles if needed, but only lines.

Have you considered the ggpattern package? It allows hatching type patterns to be plotted on polygons, which could be applied to your case with some finessing.

Atul

On Fri, Aug 4, 2023 at 3:12 PM Ellis Patrick @.***> wrote:

Hi Atul,

I have a hatching function in my package lisaClust which is super slow! I just got very excited when I saw this package.

Is there a way to make the colour of the points (maybe cell types) different to the hatching (some sort of region) with scatterHatch so that I can generate plots like the ones at the bottom of https://www.biorxiv.org/content/biorxiv/early/2022/04/19/2022.04.19.488697/F5.large.jpg?width=800&height=600&carousel=1

Or is there an equivalent to the geom_hatching() in lisaClust?

Also, have you had any thoughts in extending this past 7 hatching patterns?

Thanks, Ellis

— Reply to this email directly, view it on GitHub https://github.com/FertigLab/scatterHatch/issues/12, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDSCIK25UZF44TUNO7X5Y3XTVCRXANCNFSM6AAAAAA3ES46PI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHubhttps://github.com/FertigLab/scatterHatch/issues/12#issuecomment-1666083383, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACAALBOXQLWFIUG67EIHF7TXTVFL7ANCNFSM6AAAAAA3ES46PI. You are receiving this because you authored the thread.Message ID: @.***>