search

Fesch-star / cognitivemapr

Once the coding stage of your cognitive mapping (CM) project is done, there are many analyses and calculations you can do. Find some useful functions here to help you analyse your CM data
https://fesch-star.github.io/cognitivemapr/
GNU General Public License v3.0
2 stars 3 forks source link

Check pull requests in development branche #46

Closed Fesch-star closed 6 months ago

Fesch-star commented 7 months ago

Hi Jelle,

I made some more changes over the past days and pushed them to the development branche. Somehow they all appear below each other and make up one layered (?) pull request.

Could you check the changes and see if they can be merged into main? The second commit does not pass all test, I expect the third also not to pass as I changed 3 functions. Thanks, Femke

jelletreep commented 6 months ago

Hi @Fesch-star, Yes, until someone merges the Pull request (PR), it is still possible to add new commits to the branch and the PR will be automatically updated. This is handy since it is good practice to let someone review a PR, and if the review leads to revisions it is ease to implement them before merging. When merging we can still decide to keep all the original commits of the development branch, or 'Squash' all changes into one commit. I have made some changes to the development branch to fix the Package build issues. I will add a message to the pull request, and then you can merge it!

Fesch-star commented 6 months ago

checked and merged the pull request