Festify / cordova-spotify-oauth

🔐 Easy Spotify authentication for Cordova / PhoneGap apps
MIT License
16 stars 18 forks source link

forget() doesn't logout user completely #8

Open gregorymaertens opened 6 years ago

gregorymaertens commented 6 years ago

Hello,

when calling forget(), it clears the auth data in local storage so the oauth can start again. However, since it uses native web views and cookies are not cleared, one faces the same issue as described by this user: https://github.com/spotify/ios-sdk/issues/151 Basically the data from the previous user remains in the webview.

Is it possible to have a way to perform completely a logout? => clear the cookies? Not sure it's the best way with SFSafariWebView => open logout page for spotify auth (didn't find the URL). See https://github.com/OAuthSwift/OAuthSwift/wiki/Logout

Thanks! Greg

mraerino commented 6 years ago

Thanks for the suggestion!

One could certainly clear the cookies of the Spotify auth domain. Calling the logout page seems a little complicated.

We are not really focussing on maintaining this plugin currently, but if you'd like to prepare a PR, we'd be really happy.