FestiveCat / pe

0 stars 0 forks source link

Too many similar commands that can be confusing #12

Open FestiveCat opened 2 years ago

FestiveCat commented 2 years ago

Almost all commands are duplicated between buyer and sellers, ie: add-s, add-b, list-s, list-b etc.

Lots of information is repeated and can be hard to keep track of. A better way possibly is to have a single add command that takes in an additional parameter to indicate if it is for the seller or buyer.

(Also makes the UG unnecessarily verbose and long winded)

nus-se-bot commented 2 years ago

Team's Response

Firstly, many different commands are more convenient. If i want to edit a buyer, we just do edit-b for example. It is even faster than editing a prefix for edit c/buyer for example.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: It is indeed faster, but it incurs additional overhead for users to remember the differences between each command. Additionally, if a user accidentally performs a command wrongly, there is no "undo" function to rewind back.

Comparison to a real-life example: Linux's "ls" command

There is no separate "ls-a" command, nor is there a separate "ls-l" command. It is all the same "ls" command. The additional parameter does not necessary have to be c/buyer. It can be -b and -s accordingly.