FestiveCat / pe

0 stars 0 forks source link

find-b does not find type=any/unspecified for provided housing type!=any/unspecified #8

Open FestiveCat opened 2 years ago

FestiveCat commented 2 years ago

Shi Hong has housing type of any/unspecified:

image.png

After doing find-b h/hdb:

image.png

Shi Hong is nowhere to be found. Not sure if this is intended or not, but a specification of "any" would be more logical that finding any non-any types will also return them. This is equivalent to saying that buying an apple for someone who does not mind any kind of fruit is wrong.

nus-pe-script commented 2 years ago

Team's Response

This is intended. Our find feature is meant to search the specific keywords as specifically as possible. If almost every client has unspecified house type, then you do find-b h/hdb, the resulting list will be very long which defeats the purpose! Our unspecified means any, not every, so hdb is not necessarily a subset of unspecified.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: > If almost every client has unspecified house type, then you do find-b h/hdb, the resulting list will be very long which defeats the purpose!

Find-b h/hdb should list out the very long list, so that the user can see which of the sellers should they match, instead of restricting to just purely people who put "hdb".

If anything, an additional tag can be used to prevent or allow the search of "any" together with search of anything that is not "any".

Alternatively, an explanation/note can be added about the behaviour of the "find" command can confuse people who expect one way or another.

Our unspecified means any, not every, so

A buyer willing to buy any kind of housing should be okay with every kind of housing. There is no difference here.

hdb is not necessarily a subset of unspecified.

This is true, if "unspecified" was not lumped together with "any". By just using "unspecified", benefit of the doubt can be given that the buyer did not specify what they want. By using "any", the buyer should have given the opinion that they are okay with any housing type.

Hence, because there is no distinction between "unspecified" and "any", this entire issue arose. Your team implemented it according to how the behaviour of "unspecified" would be, but the inclusion of "any" caused the ambiguity and mess as they have different requirements.


:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]