Festo-se / cyclonedx-editor-validator

Tool for creating, modifying and validating CycloneDX SBOMs.
https://festo-se.github.io/cyclonedx-editor-validator/
GNU General Public License v3.0
18 stars 4 forks source link

docs: Improve command documentation #185

Closed mmarseu closed 3 months ago

mmarseu commented 4 months ago

Changes to available_commands.md:

github-actions[bot] commented 4 months ago

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL16107195% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
287 2 :zzz: 0 :x: 0 :fire: 4.467s :stopwatch:
CBeck-96 commented 4 months ago

Are there plans to also add the other commands beside add-license-text to the documentation at a later time?

mmarseu commented 4 months ago

Are there plans to also add the other commands beside add-license-text to the documentation at a later time?

That's a valid point. I've only reworked the add-license-text section because it was already there. It could be argued that either we document all operations or none at all. Certainly, add-license-text is a little more complex than the others because it requires the user to provide files in a certain form. Ideally, we'd be able to automatically include the docstrings from the operation classes into the documentation. Possibly via #177?

CBeck-96 commented 3 months ago

That's a valid point. I've only reworked the add-license-text section because it was already there. It could be argued that either we document all operations or none at all. Certainly, add-license-text is a little more complex than the others because it requires the user to provide files in a certain form. Ideally, we'd be able to automatically include the docstrings from the operation classes into the documentation. Possibly via #177?

I think for now thats a sufficient argument. The documentation for the easier/more intuitive to use operations can wait till we made progress on #177.

italvi commented 3 months ago

@mmarseu Please resolve the conflict, otherwise no further comments 😁