Closed mmarseu closed 3 weeks ago
Should the documentation be updated? It can be kept as is, since the information is not wrong, but the case of several input files is not covered. This might be worth mentioning, since using the input function, the merging order can be influenced (input is merged in order before the folder which contents are merged alphabetically)
Valid point. The documentation should be improved.
That made me think: Is there any point to requiring an input argument when --from-folder
is given? Since merge order is often important, the user has to make sure to name the files in the folder correctly anyways. Then why do we force them to single out the "primary" merge input, if it could simply be the first file in the folder in alphabetical order?
Should the documentation be updated? It can be kept as is, since the information is not wrong, but the case of several input files is not covered. This might be worth mentioning, since using the input function, the merging order can be influenced (input is merged in order before the folder which contents are merged alphabetically)
Valid point. The documentation should be improved.
That made me think: Is there any point to requiring an input argument when
--from-folder
is given? Since merge order is often important, the user has to make sure to name the files in the folder correctly anyways. Then why do we force them to single out the "primary" merge input, if it could simply be the first file in the folder in alphabetical order?
Good point. Now that you mention it, it would be more natural to justb (want to) merge a folders contents.
Should the documentation be updated? It can be kept as is, since the information is not wrong, but the case of several input files is not covered. This might be worth mentioning, since using the input function, the merging order can be influenced (input is merged in order before the folder which contents are merged alphabetically)
Valid point. The documentation should be improved. That made me think: Is there any point to requiring an input argument when
--from-folder
is given? Since merge order is often important, the user has to make sure to name the files in the folder correctly anyways. Then why do we force them to single out the "primary" merge input, if it could simply be the first file in the folder in alphabetical order?Good point. Now that you mention it, it would be more natural to justb (want to) merge a folders contents.
Done. Tests will be added to #157
Overhauls the loading of input files in
invoke_merge()
.--from-folder
is given and the folder contains at least two input files.--from-folder
that are also specified as positional arguments are no longer merged twice.This is a breaking change for two reasons:
Tests for the new behavior will be added to #157.