155 merge vex reference check doesnt take nested components into account

Festo-se / cyclonedx-editor-validator

Tool for creating, modifying and validating CycloneDX SBOMs.

https://festo-se.github.io/cyclonedx-editor-validator/

GNU General Public License v3.0

18 stars 4 forks source link

155 merge vex reference check doesnt take nested components into account #202

Closed CBeck-96 closed 2 months ago

CBeck-96 commented 3 months ago

closes #155 depends on #154

github-actions[bot] commented 3 months ago

Coverage Report •

File	Stmts	Miss	Cover	Missing
merge_vex.py	32	1	96%	73
TOTAL	1684	91	94%

Tests	Skipped	Failures	Errors	Time
298	2 :zzz:	0 :x:	0 :fire:	5.061s :stopwatch:

italvi commented 2 months ago

@CBeck-96 do you really want to add this now without tests? As a rework of vex is planned, I am uncertain whether this half PR is justified.

CBeck-96 commented 2 months ago

@CBeck-96 do you really want to add this now without tests? As a rework of vex is planned, I am uncertain whether this half PR is justified.

It closed an issue with < 5min works... But it will probably be not relevant, depending on the new vex functions

italvi commented 2 months ago

@CBeck-96 do you really want to add this now without tests? As a rework of vex is planned, I am uncertain whether this half PR is justified.

It closed an issue with < 5min works... But it will probably be not relevant, depending on the new vex functions

Still, it misses test. Please either add tests or close this PR for the time-being, waiting for the rework of merge-vex

CBeck-96 commented 2 months ago

Since merge vex is deprecated, PR will be closed until the feature is reworked.