search

Feu-Secret / Tokenmagic

A Foundry VTT module that allows you to add animations and graphic effects to tokens, tiles, templates and drawings.
GNU General Public License v3.0
51 stars 36 forks source link

[BUG] TMFX breaks/cancels all light underneath overlapping overhead tiles #222

Open baileywick opened 1 year ago

baileywick commented 1 year ago

Module Version: v0.6.1.2

Before open any issue console errors attached. console-errors-1665100226981.log

Describe the bug Whenever there are two overhead tiles in a scene, and those tiles are overlapping in any way, all lighting under or above the overlap is rendered inert. This only happens when TMFX is enabled and active in the world. No other modules active.

To Reproduce

  1. create two overhead tiles in a scene. Overlap them any way you like.
  2. put a light under or near the overlapping area of the tiles
  3. place a token under the overlapping area of the tiles
  4. you will see that the light does not render around the token

Expected behavior Expecting to see lights shine properly in a scene with overlapping overhead tiles.

Screenshots

Overhead Tile Configuration over-tile-configuration

Expected expected

Actual/Bug actual

Browser: Brave (Chromium)

Foundry Version: v10 build 287

Game System: dnd5e

Additional context This prevents the ability to use TMFX in any scene with multiple overhead tiles, including Levels-enabled scenes that have multiple overhead tiles required to constitute a building.

fvtt-Scene-tmfx-troubleshoot.txt fvtt-Scene-shipyard-prefab-repair.txt

Feu-Secret commented 1 year ago

Thanks for the report. I will investigate it and try to fix it for the next release.

baileywick commented 1 year ago

Interestingly, I opened another session and couldn't replicate the problem. I'm afraid something else is a factor here, too.

On Thu, Oct 6, 2022, 11:52 PM Ludovic (SecretFire) @.***> wrote:

Thanks for the report. I will investigate it and try to fix it for the next release.

— Reply to this email directly, view it on GitHub https://github.com/Feu-Secret/Tokenmagic/issues/222#issuecomment-1271182497, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADMLTXVGEO3IZLS7DD6IDKLWB7CBRANCNFSM6AAAAAAQ7DRYNQ . You are receiving this because you authored the thread.Message ID: @.***>

OsiJr commented 1 year ago

Your error logs indicate you had tiles that were <= 0 width and height? Might be something there.

Do you still have those errors in the console with it now working?

baileywick commented 1 year ago

I'm afraid this bug is back. And I can reproduce it reliably.

PROBLEM: If there are two overhead tiles that have TMFX filters applied to them, the overlapping area does not allow light to shine. This is specifically when using the following modules:

Ripper thinks it's a problem with TMFX.

No console errors.

Scene export is attached, if it helps.

baileywick commented 1 year ago

fvtt-Scene-shipyard-prefab-repair.txt fvtt-Scene-tmfx-troubleshoot.txt

These are two sample scenes (.json changed to .txt so they would upload). You'll see that scene only has a single TMFX tile, and it still blocks light.

Feu-Secret commented 1 year ago

This problem is related to core. I know how to solve it.