BUG: Drop Shadow degrades quality of the tile. Blurs it.

Feu-Secret / Tokenmagic

A Foundry VTT module that allows you to add animations and graphic effects to tokens, tiles, templates and drawings.

GNU General Public License v3.0

51 stars 36 forks source link

BUG: Drop Shadow degrades quality of the tile. Blurs it. #232

Closed baileywick closed 1 year ago

baileywick commented 1 year ago

Whenever the Drop Shadow filter is applied, using any settings, it appears to blur the tile it's applied to, degrading the quality of it. Not sure if there is anything to do about this. drop-shadow

LukasPrism commented 1 year ago

Would love to see this fixed so Flying Tokens module doesn't result in blurry tokens

Aedif commented 1 year ago

Would love to see this fixed so Flying Tokens module doesn't result in blurry tokens

Does it happen only on specific tiles/tokens? I'm not noticing this at all 🤔

baileywick commented 1 year ago

I've had trouble replicating this since posting. I don't know if it was a module conflict or something else, but it seems to be corrected now.

On Fri, Feb 10, 2023, 12:49 PM M. Vaitkus @.***> wrote:

Would love to see this fixed so Flying Tokens module doesn't result in blurry tokens

Does it happen only on specific tiles/tokens? I'm not noticing this at all 🤔

— Reply to this email directly, view it on GitHub https://github.com/Feu-Secret/Tokenmagic/issues/232#issuecomment-1426263116, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADMLTXXAXHBFE5ILGKLWJN3WW2LUHANCNFSM6AAAAAAS3EMLLY . You are receiving this because you authored the thread.Message ID: @.***>

Aedif commented 1 year ago

As I am unable to reproduce it and the reporter hasn't seen it since either I'm closing the issue.

Feel free to re-open it if you come across it again.

LukasPrism commented 1 year ago

I just got pinged about this and it reminded me to take a look. I know how to reproduce it now – you need to have the core setting Pixel Ratio Resolution Scaling on (on a high dpi monitor).

What it looks like is happening is the token is excluded from the scaling – so it will be blurry as if the scaling is turned off. When I turn off scaling basically the whole canvas looks as blurry as the token with the drop shadow TMFX.

Here's the scene with scaling on:

Scaling off:

Scaling on with drop shadow on the selected token:

Not sure if there's anything you want to do about this... would only affect those with high-dpi screens. I'm using a MacBook so noticed it.

Aedif commented 1 year ago

Should be resolved in release v0.6.3