Feu-Secret / Tokenmagic

A Foundry VTT module that allows you to add animations and graphic effects to tokens, tiles, templates and drawings.
GNU General Public License v3.0
51 stars 36 forks source link

Added vite integration to create a project bundle js and reduce the number of calls #259

Open p4535992 opened 10 months ago

p4535992 commented 10 months ago

Added vite integration to create a project bundle js and reduce the number of calls

p4535992 commented 3 months ago

Re-uploaded some stuff i add some util to export the source of hte packs and some better vite build utility.

Rughalt commented 3 months ago

I would wait with that until we merge the release script - and update the script with vite build once we know the basic process based of NPM works. Wtyd @p4535992 ?

p4535992 commented 3 months ago

Sorry what does “Wtyd” mean ! In the past I used it in game for the phrase “Welcome to your death” XD.

No rush ... by the way i just see a alternative solution with npx and rollup for this on the black flags system, maybe is even better ?

Abourass commented 2 months ago

Sorry what does “Wtyd” mean ! In the past I used it in game for the phrase “Welcome to your death” XD.

No rush ... by the way i just see a alternative solution with npx and rollup for this on the black flags system, maybe is even better ?

I think they just misspelled "WDYT" (What do you think?)

I think Vite brings a better level of support. It uses rollup under the hood but has not only an easier DX for setting up ways to make the bundle more efficient, but also has they added bonus of being easily integrated with Vitest for unit testing.