Feuerlabs / exodm

Top project for Exosense DM release management
1 stars 1 forks source link

Extra comma in yaws file #3

Open rsharvey opened 9 years ago

rsharvey commented 9 years ago

ERL: OTP 17.4 Exodm: master

On line 800 of the deps/yang/yang_validate.erl file there is what looks like an extra comma. Look after "none":

rule('type') ->
    {'type',identifier_ref,
     ?ALL(0,none‚,[
           ?Y(0,1,'fraction-digits'), %% decimal64
           ?Y(0,1,'range'),   %% numerical
           ?Y(0,1,'length'),
           ?Y(0,n,'pattern'),  %% string
           ?Y(0,n,'enum'),   %% enum
           ?Y(0,1,'path'),   %% leafref FIXED: RFC6020 - Errata ID 2949
           ?Y(0,1,'base'),   %% identityref
           ?Y(0,1,'require-instance'),  %% instance-identifier
           ?Y(0,n,'bit'),               %% bits
           ?Y(0,n,'type')               %% union
          ])};
uwiger commented 9 years ago

It's actually not a regular comma, but still, it should not be there, and has been removed in

https://github.com/Feuerlabs/yang/commit/6e05025917216ec3c95797477beafe734f2a244b

It only seems to matter in OTP 17, since it made the move over to UTF-8 encoding of source files.