Suggest method parameter should be an attribute

[Luro02]

What it does

When a sufficiently large class, has a lot of methods that take the same parameter, it would make sense to have this as an attribute.

Potential Problems

• Parameter might be necessary, because method is called with many different values (attribute only makes sense if it is always the same)
• records can only be initialized once (every attribute is final -> for every method invocation the param would have to be the same)

Lint Name

PARAMETER_SHOULD_BE_ATTRIBUTE

Category

oop

Example

class A {
    void a(String name) { /* ... */ }
    void b(String name) { /* ... */ }
    void c(String name) { /* ... */ }
    void d(String name) { /* ... */ }
    void e(String name) { /* ... */ }
    void f(String name) { /* ... */ }
}

Could be written as:

class A {
    String name;

    void a() { /* ... */ }
    void b() { /* ... */ }
    void c() { /* ... */ }
    void d() { /* ... */ }
    void e() { /* ... */ }
    void f() { /* ... */ }
}