Suggest `SomeListing.of(1, 2, 6, ...).contains(c)` in place of `c == 1 || c == 2 || c == 6 ....`

[Luro02]

What it does

Simplifies complex boolean expressions into shorter ones that are easier to read.

Some things to be careful of:

• There should be at least X elements in the resulting list (maybe X=3?)
• There should be at least one java.util import in the model (so list can be used)
• Instead of List, one could use Set instead
• Ignore expressions comparing with null like a == null || a == 1 || a == 2

Lint Name

USE_LISTING_CONTAINS

Category

complexity

Example

class Test {
    boolean isValid(char ch) {
        return ch == 'N' || ch == 'S' || ch == 'O' || ch == 'W' || ch == 'n' || ch == 's' || ch == 'o' || ch == 'w';
    }
}

Could be written as:

class Test {
    boolean isValid(char ch) {
        return List.of('N', 'S', 'O', 'W', 'n', 's', 'o', 'w').contains(ch);
    }
}