search

Fevol / obsidian-criticmarkup

Annotate notes with comments and suggestions using CriticMarkup in Obsidian
MIT License
136 stars 2 forks source link

Metadata is not added automatically to ranges when editing in suggestion mode #11

Open kinglion580 opened 6 months ago

kinglion580 commented 6 months ago

mode is suggestion:

Metadata is not added automatically to ranges when editing in suggestion mode: image

add metadata is on: image

Fevol commented 6 months ago

By all accounts, that combination of settings should result in metadata being added. Did you also enable "Include Metadata Extension" in the General settings

kinglion580 commented 6 months ago

yes, I enabled "Include Metadata Extension" image

Fevol commented 6 months ago

Thanks for the quick response! I think I have a general idea as to why this is not working: COMMENTATOR_GLOBAL.PLUGIN_SETTINGS is currently used to generate which metadata should be added

If you are a bit familiar with the dev tools, if you debug in the function: function generate_metadata(), you should be able to find what the value for that object is at that moment. If COMMENTATOR_GLOBAL.PLUGIN_SETTINGS.add_metadata or any of the other add_... settings are false, that should be the issue.

(I've also attached a build that console.log's these values for you:) commentator.zip