Fevol / obsidian-criticmarkup

Annotate notes with comments and suggestions using CriticMarkup in Obsidian
MIT License
136 stars 2 forks source link

double period #14

Open Eusorph opened 5 months ago

Eusorph commented 5 months ago

In Suggestion mode, when typing one period (.), Commentator adds another period and deletes one space from the following word (I have deletions in front in this example) Also, in editing (alt), when adding a period it deletes one space of code of the deletion preview following.


Debugger data (do not alter)

plugin_version: "0.2.0" platform: "Desktop" framework_version: "1.5.8" obsidian_version: "1.5.11"

Fevol commented 5 months ago

Thanks for the issue report! If possible, could you share a picture of the text (in source mode, can be enabled via: Toggle Live Preview/Source mode) and cursor location when this error occurs? I have not been able to reproduce it myself so far.

Eusorph commented 5 months ago

Hi, First all, the main problem seemed to be the "automatic tag correction" feature in the settings. When I unchecked, the problems stopped. BUT After downloading MAKE.md, I started suddenly having problems again. With Make.md active in the text below this would happen: 1)After marking the two bottom lines as "deletions" 2) When I tried to write M04 of the green "addition" line, suddenly it would jam M04 together with the M04 on the deletion line right below, while also clumping together the two deleted paragraph. It would delete some text and also mark part of the first deleted paragraph undeleted.

Once I unchecked Make.md, the behaviour stopped. So, right now, it seems Commentator has conflicts with "Smart Typography" and "Make.md". I hope you'll resolve this issues because I find Commentator extremely useful in the way I work.

Best,

Lapo

[image: capture_20240322154632195.bmp]

Il giorno gio 21 mar 2024 alle ore 19:58 Fevol @.***> ha scritto:

Thanks for the issue report! If possible, could you share a picture of the text (in source mode, can be enabled via: Toggle Live Preview/Source mode) and cursor location when this error occurs? I have not been able to reproduce it myself so far.

— Reply to this email directly, view it on GitHub https://github.com/Fevol/obsidian-criticmarkup/issues/14#issuecomment-2013337893, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHHPE7KT7EKWMUGWQ7ZT7FLYZMUWXAVCNFSM6AAAAABE7PE7F6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJTGMZTOOBZGM . You are receiving this because you authored the thread.Message ID: @.***>

Eusorph commented 5 months ago

Here is the actual text, if you want to test it.

L’urlo del cane divenne un gemito d’agonia pieno di terrore e confusione.

M04 cercò di spegnere i fulmini, annaspò nell'ebrezza di furore che gli bruciava il cervello, ma la tempesta di fuoco che gli bruciava dentro lo accecava. Cercò di fermarsi, ma non poteva, non riusciva.

M04 cercò di spegnere i fulmini, annaspò nella tempesta di fuoco e sangue che gli bruciava il cervello, cercò di fermarsi, ma non poteva, non riusciva.

M04 cercò di spegnere il proprio corpo, annaspò nella tempesta di fuoco e sangue che gli bruciava il cervello, cercò, ma il furore lo accecava dentro di lui aveva rotto gli argini. Cercò di fermarsi, ma non poteva, non riusciva. L’ebrezza di furore che lo scuoteva aveva preso la sua volontà e l’aveva annegata in una tempesta di fuoco e sangue che lo soverchiava.

Il giorno ven 22 mar 2024 alle ore 15:54 Lapo Melzi @.***> ha scritto:

Hi, First all, the main problem seemed to be the "automatic tag correction" feature in the settings. When I unchecked, the problems stopped. BUT After downloading MAKE.md, I started suddenly having problems again. With Make.md active in the text below this would happen: 1)After marking the two bottom lines as "deletions" 2) When I tried to write M04 of the green "addition" line, suddenly it would jam M04 together with the M04 on the deletion line right below, while also clumping together the two deleted paragraph. It would delete some text and also mark part of the first deleted paragraph undeleted.

Once I unchecked Make.md, the behaviour stopped. So, right now, it seems Commentator has conflicts with "Smart Typography" and "Make.md". I hope you'll resolve this issues because I find Commentator extremely useful in the way I work.

Best,

Lapo

[image: capture_20240322154632195.bmp]

Il giorno gio 21 mar 2024 alle ore 19:58 Fevol @.***> ha scritto:

Thanks for the issue report! If possible, could you share a picture of the text (in source mode, can be enabled via: Toggle Live Preview/Source mode) and cursor location when this error occurs? I have not been able to reproduce it myself so far.

— Reply to this email directly, view it on GitHub https://github.com/Fevol/obsidian-criticmarkup/issues/14#issuecomment-2013337893, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHHPE7KT7EKWMUGWQ7ZT7FLYZMUWXAVCNFSM6AAAAABE7PE7F6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJTGMZTOOBZGM . You are receiving this because you authored the thread.Message ID: @.***>

Eusorph commented 5 months ago

I checked again and the problem is some kind of conflict with "Smart Typography" and "Make.md." I always checked with "automatic tag correction" off and text got jumbled in crazy ways. Hope you can figure it out.

Eusorph commented 5 months ago

With Make.md activated something very peculiar happens with additions: words get almost doubled and mirrored. I paste the example below I obtained by typing the words. If you look, you'll noticed that second, third and fourth words are mirrored. The first work is mirrore word but cutoff at the first letter.

M04 spaziò lo sguardo febbricitante attraverso la stanza, enorme attorno a lui. Gli bruciavano gli occhi. Gli bruciava la bocca e sentiva un sapore rauco, di sangue, in fondo alla gola. {++Se tutto quello che ehc olleuq ottut e++}to, e l’aria gli entrava nei polmoni con un sibilo doloroso. Tutto bruciava dentro di lui e gridava “Pericolo! Pericolo!”.