search

Fevol / obsidian-criticmarkup

Annotate notes with comments and suggestions using CriticMarkup in Obsidian
MIT License
147 stars 2 forks source link

Allow "Accept Changes" to Delete Comment? #17

Open kerim opened 5 months ago

kerim commented 5 months ago

RIght now, adding a comment shows it on the sidebar, but I would like to be able to also delete comments from the sidebar as well. Each comment shows the check and "X" for accepting or rejecting changes, but these don't seem to do anything for comments. I'd like to be able to use the checkmark to delete comments I've already processed. This is similar to how comments work in Google Docs.

lifehaschanged commented 5 months ago

Hello Kerim. Sorry for the question - I am new to this plugin: How do you make the comment sidebar visible? I have no command for this after installing the plugin.

lifehaschanged commented 5 months ago

Did you install it with BRAT or manually, because with BRAT I have no commands or sidebars visible in a fresh sandbox vault?

kerim commented 5 months ago

There is a button at the top of the sidebar that gives you a few of all suggestions and/or comments. You can cycle between showing them for the individual file, the current folder, or the entire vault. I used BRAT to install.

lifehaschanged commented 5 months ago

Thanks, I opened a new Issue. And +1 for your FR.

Fevol commented 5 months ago

Thank you for the feature request! Currently this is indeed unimplemented as I still need to work out how the comment resolving workflow should be added. (E.g. mark as completed using metadata and still being available for later reference, or completely removing it)

Currently the development of the plugin is on hold as I am trying to focus on other work, but I should finally be able to get around to this in a month's time.