search

Fevol / obsidian-criticmarkup

Annotate notes with comments and suggestions using CriticMarkup in Obsidian
MIT License
136 stars 2 forks source link

Edits of the suggestion #5

Closed felipemeres closed 6 months ago

felipemeres commented 10 months ago

Incredible plugin, thank you so much for working on it! I'm wondering if it would be possible to add a setting so that edits to suggestions don't get crossed out if edited but actually just permanently edit the suggestion.

Fevol commented 10 months ago

Just so I understand correctly, is this somewhat the situation you're envisioning? I.e. (1) instead of (2):

  1. {++abc░++} ---(backspace)--> {++ab░++} (c gets fully deleted)
    1. {++abc░++} ---(backspace)--> {++ab░++}{--c--} (c gets marked as a deletion)

If so, this is definitely something I'm planning to add when I finally get around to the suggestion mode rewrite. My main goal is recreating the behaviour of Google Docs' suggestion mode, for better and worse, though with the addition of being able to fully delete characters while pressing the modifier key Alt, for example. (And having a command to invert the behaviour at will)

huachuman commented 8 months ago

Level 10,000 developer here ^

You can just tell because of the way it is.

You are on a rocket to success my friend.

Thank you for this superb plugin.

Fevol commented 6 months ago

Thank for the patience, with version 0.2.0, there are now two different solutions to this problem:

  1. In suggestion mode, when strictly in the addition or the addition-part of a substitution, a delete will always remove the text (similar to how Google Docs' logic works)
  2. In alternative editing mode (the new default editing mode), you can directly insert and delete text from any suggestion