search

Fevol / obsidian-criticmarkup

Annotate notes with comments and suggestions using CriticMarkup in Obsidian
MIT License
136 stars 2 forks source link

[BUG] Comments are not hidden #7

Closed caglarongan closed 6 months ago

caglarongan commented 7 months ago

Comments are not hidden even though I've selected "inline-icon" or "inline" rendering selected.

Screenshot 2024-02-07 at 03 25 14 Screenshot 2024-02-07 at 03 25 10

Very high-quality plugin, very appreciated! Thanks and congrats :)

Fevol commented 7 months ago

Thank you for the bug report, and the kind words!

I think that you are currently in Source Mode, which is why the comments are not being shown as an icon. Could you test if Toggle Live Preview/Source mode solves the issue?

caglarongan commented 7 months ago

Ah yes, it works as expected in Live Preview. Thank you.

But for Reading Mode, it's still rendered inline and not hidden.

Also, multi-line comments are rendered like this:

source view reading mode
Fevol commented 6 months ago

Thank you for the bug report, with the latest version 0.2.0, the comments are now rendered like in live preview mode (i.e. comment icon), when hovering over the icon, the comment contents will appear.

If you have suggestions on how to improve comment rendering in reading mode, please feel free to open up a new issue!