Fevol / obsidian-translate

Translate text and entire notes in Obsidian
MIT License
100 stars 6 forks source link

[BUG] Plugin breaks "More options" menu #45

Closed AntonTheDeveloper closed 1 year ago

AntonTheDeveloper commented 1 year ago

User report

After installing this plugin and enabling it, I have got my "More options" menu broken. It doesn't scroll and has broken layout as long as the plugin is enabled. I have reproduced this bug on my usual vault and on newly created vault.

Here screenshot and video https://github.com/AntonTheDeveloper/bug-reports/tree/37e850c48cc6684c7a46d6734007621038b21d0e/obsidian-translate


Debugger data (do not alter)

plugin_version: "1.4.4" platform: "Desktop" framework_version: "1.1.16" obsidian_version: "1.1.16" selected_service: "google_translate"

Fevol commented 1 year ago

Many thanks for the detailed bug report! The issue was from an older bodge I used to add my own submenu's, since it wasn't natively supported (yet).

The fix uses the recently added native submenu (which are supported from versions 1.0.0 onwards, afaik). I haven't tested if it works properly across all platforms yet, so an official release will have to be for later.

(Currently I'm both working on a different plugin and several other university projects. I will definitely be coming back to this plugin to also fix all the myriad API issues and implementing all feature requests. But that will be a little ways off.)

In the meantime, I've attached the most recent build of the plugin (which includes the fix for this issue) Most recent build (as of 2023/04/04)

Fevol commented 1 year ago

The fix is now officially shipped with update 1.4.6, apologies for the wait!