search

Fevol / obsidian-typings

Typescript typings for undocumented parts of the Obsidian API
MIT License
73 stars 13 forks source link

Contribution maintenance #70

Closed mnaoumov closed 3 months ago

mnaoumov commented 3 months ago

@Fevol your project is truly amazing. I am a huge fan of it.

But I cannot ignore the fact that your response time is quite big.

Based on your GitHub activity, you have huge gaps in your availability.

Maybe your project will benefit from including additional contributors with write permission?

If you are open to it, please consider my candidacy.

Fevol commented 3 months ago

I sincerely apologize for my lack of activity these past two months; personal circumstances made it difficult for me to develop for this project, and my other Obsidian plugins.

I'd be very grateful to have you as a (co-)maintainer for this package, and perhaps move this to an organization rather than being linked to my account. In addition, I'll try to go through all the PR's you've submitted today and tomorrow.

mnaoumov commented 3 months ago

@Fevol please consider making me a co-maintainer with push permission and ability to publish npm package until your personal circumstances drag you away again :)

(Not trying to be mean, I don't know what happened, I hope nothing too serious)

mnaoumov commented 3 months ago

@Fevol The reason I am being a bit (or not) pushy, is because I am developing a generator-obsidian-plugin and I had to use my own fork in package.json instead of your package, because it was not updating rapidly enough.

I prefer to reference your npm package instead, if possible

Fevol commented 3 months ago

I completely understand, I am currently updating the README and package.json, hence the delay. I'm adding you as soon as I'm ready with that.

Fevol commented 3 months ago

@mnaoumov You should have gotten invites for GitHub and npm. Please do let me know when you are creating a release (discord, pr, ...), I'll try my best to also review your PR's on time - to see whether it works on my set-up/in my plugins.

I have updated the workflow to also create releases containing the dist as a zip, but there may still be a bug or three.

mnaoumov commented 3 months ago

@Fevol thank you, let's make your project prosper!