search

Fewbytes / sysctl-cookbook

sysctl cookbook for Chef
9 stars 27 forks source link

Dynamic configuration file. Add LWRP. #4

Closed chrisroberts closed 11 years ago

chrisroberts commented 12 years ago
nukemberg commented 12 years ago

will be merged, will update community site after adding tests (hopefully)

chrisroberts commented 12 years ago

Are you looking for test-kitchen tests to be added? If so I would be happy to add them to get the version bump and release expedited.

nukemberg commented 12 years ago

please do.

Regards, Avishai

On IST 17:38:13 2012 נוב 12 ב', Chris Roberts wrote:

Are you looking for test-kitchen tests to be added? If so I would be happy to add them to get the version bump and release expedited.

— Reply to this email directly or view it on GitHub https://github.com/Fewbytes/sysctl-cookbook/pull/4#issuecomment-10291947.

guilhem commented 11 years ago

This type of work exist 3 times already (at least): https://github.com/spheromak/sysctl-cookbook https://github.com/Youscribe/sysctl-cookbook (mine) https://github.com/rcbops-cookbooks/sysctl

We need to work in the same way I think. What about an hangout conf all of us ?

[edited]

nukemberg commented 11 years ago 
sure. can you arrange it?Regards,

Avishai On 14/11/12 15:01, Guilhem Lettron wrote:

  This type of work exist 3 times already (at least):https://github.com/atomic-penguin/cookbook-el-sysctlhttps://github.com/Youscribe/sysctl-cookbook
    (mine)https://github.com/rcbops-cookbooks/sysctl
  We need to work in the same way I think.
    What about an hangout conf all of us ?

    —
    Reply to this email directly or view
      it on GitHub.
spheromak commented 11 years ago

I am keen to work with people on this, but Im in KST time zone. A hangout may be difficult for me to attend. As it stands my sysctl solves my problem. so I guess it represents my approach, but I am not in any way married to it. My sense is that we need a good LWRP that allows me to redefine sysctl attributes in recipe space however i feel needed. I am ambivalent to being able to search sysctl attributes. A long time ago i wrote a sysctl ohai plugin cause I thought I wanted to search against all set values, but this turned out to bloat the node object quite a bit. My lwrp is setup to only put back the attributes which you have explicitly said you want to store to alleviate this issue.

Other than that I think keeping it simple and platform independent are the other needs.

nukemberg commented 11 years ago

could not see why you used ruby_block instead of simply allowing the template it's default action. Anyway, please review the merge-in-progress branch hw-dynamic-template-lwrps-merge

chrisroberts commented 11 years ago

The ruby block is used to delay the file writing to the end of the chef run. This allows for resources defined and executed after the template resource are still picked up and applied.

nukemberg commented 11 years ago

Merged. opening issues for README and test-kitchen tests