search

Fezzzi / Peachpied-Symfony

Bachelor thesis at MFF UK
5 stars 1 forks source link

Add Versioning of Packages #4

Closed Fezzzi closed 4 years ago

Fezzzi commented 4 years ago

Versioning of packages is to match the one used in symfony.

Would also require:

Fezzzi commented 4 years ago

1) There is a issue with System.Json 4.7.0 nuget package. Both dotnet build and msbuild fail to compile any symfony component due to error MSB4018: The "WarmLibsCache" task failed unexpectedly.

more specificaly:

error MSB4018: System.IO.FileNotFoundException: Could not load file or assembly 'System.Json, Version=2.0.8.0, Culture=neutral, Publ
icKeyToken=31bf3856ad364e35' or one of its dependencies. The system cannot find the file specified.

2) Slight refactoring of the props file is on place. Should rename both loadPropsConfig and buildPropsConfig to more comprehensive names.

3) It would be probably required to perform some changes in structure before creating PR to avoid conflict with #5 . However, might as well resolve this on other branch.

Fezzzi commented 4 years ago

  1. It is necessary to handle circular dependencies that does not contain any dev edge as those will further result in errors during package sorting.

  2. ResolveReferences task needs to be executed before Restore target as I was unable to force PackageReference property update propagation through <CallTarget Targets="..." /> task with any combination of targets that are normally called prior to the Restore target. However, calling ResolveReferences task before the Restore target results in exception as this task is a part of PSTools nuget package. When the task is provided via static .dll everything works fine. Different approach when the ResolveReferences task was hooked before the Restore target and I attempted to restore PSTools nuget manually resulted in PSTools.dll link error.

Fezzzi commented 4 years ago

Merged here