search

Fi0x / EDCT

EDCT is a tool for large quantity trades in Elite: Dangerous. It is very useful for fleet carrier owners
MIT License
16 stars 1 forks source link

Carrier Profit is incorrect #121

Closed msteele999 closed 1 year ago

msteele999 commented 1 year ago

Describe the bug

Carrier profit is reporting as 0.00 for some combinations (see screen shot)

To Reproduce

Version: 2.1.1.0 Steps to reproduce the behavior:

  1. ...

Expected behavior

...

Screenshots

Snag_8677e3a

Additional context

...

msteele999 commented 1 year ago

Seems to be when the Galactic average is set below 1,140!

Weird Snag_86d2697

Fi0x commented 1 year ago

That's a safety feature and not a bug:

The game only allows your carrier prices to be at least 5% and at most 1000% of the galactic average price.

In your first screenshot you have Bauxite selected, which has a galactic average price of 1140cr. Buying it at at Klein Survey for 10682cr would reqire your carrier buy price to be at 22682cr to give the traders the 12000cr/t profit you selected in the settings. The maximum price to buy you can select on your carrier is 11400cr (1000% gal. avg. of Bauxite), so the tool uses this price as the Buy Price. I'm not sure why the sell-price is 11400cr as well, because that should be lower to give the 12000cr profit to the unloading traders.

I'll look into this to see if I can find out what's wrong with my logic.

msteele999 commented 1 year ago

That makes all kinds of sense!

sent from my mobile device.

On Sat, Dec 3, 2022, 16:33 Fi0x @.***> wrote:

That's a safety feature and not a bug:

The game only allows your carrier prices to be at least 5% and at most 1000% of the galactic average price.

In your first screenshot you have Bauxite selected, which has a galactic average price of 1140cr. Buying it at at Klein Survey for 10682cr would reqire your carrier buy price to be at 22682cr to give the traders the 12000cr/t profit you selected in the settings. The maximum price to buy you can select on your carrier is 11400cr (1000% gal. avg. of Bauxite), so the tool uses this price as the Buy Price. I'm not sure why the sell-price is 11400cr as well, because that should be lower to give the 12000cr profit to the unloading traders.

I'll look into this to see if I can find out what's wrong with my logic.

— Reply to this email directly, view it on GitHub https://github.com/Fi0x/EDCT/issues/121#issuecomment-1336262046, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRMUYKHNS2X2OC6WNHNKY3WLO4DJANCNFSM6AAAAAASS4RRAM . You are receiving this because you authored the thread.Message ID: @.***>