search

FiTRSkills / ForkInTheCode

Fills the skills gap in the market by allowing job seekers to find valuable skills and courses to learn them
1 stars 1 forks source link

Make front end error handling more robust #51

Open Lixnir opened 3 years ago

Lixnir commented 3 years ago

Right now when an error comes in we assume it has all the proper bits but I've run into instances where it freaks out since the error doesn't have those bits for some reason, so we need to check instead of assuming.

Lixnir commented 3 years ago

Also include the discussion about if the no error state in react should be an empty error string or a null error object

dungtran3864 commented 3 years ago
  1. In JobSearchForm.js, the error in loadSkills is not truly handled, only being logged.
  2. In Login.js, why is the email/password incorrect error handled twice?
  3. In JobSearch.js, initial state of errorMessage should be null to be conform to standard.