search

FichteFoll / discordrp-mpris

Discord Rich Presence through media players providing the mpris2 dbus interface
MIT License
86 stars 19 forks source link

Overwrite player icon using config option #35

Open mariuszste opened 1 year ago

mariuszste commented 1 year ago

Since discord can accept any valid image URL as the icon for rich presence it would be nice to be able to overwrite that for any player. This is especially useful for new players that don't have an icon built in.

things to consider: how would this interact with #32 Discord actually has 2 slots for icons, so maybe we can put the player icon in the small circle one and the album over in the big one?

FichteFoll commented 1 year ago

Yes, it's a good idea to implement this together with #32.

FichteFoll commented 1 year ago

This is possible now via the client_id (de9d532fa0fffd147aa00e38e7a626c3c0547482) and icon (dbeed4f6cc39ad5ad0d66469193c4103823e58b7) configuration options. This does support HTTP URLs already, which I actually forgot to document, so I'm considering this to be done for the next release (whenever I get around to packaging that because I changed a few things that I'll need to test first and would also like to implement a few more things until then).

mariuszste commented 1 year ago

Awesome, thanks. Moving more things to the config is definitely welcome.