search

FidalMathew / Poke-dex

Pokedex- search any pokemon and get its picture and its type
https://fidalmathew.github.io/Poke-dex/
7 stars 9 forks source link

Implemented lightmode/darkmode functionality #11

Closed vaibhav-1508 closed 1 year ago

vaibhav-1508 commented 1 year ago

Implemented dark mode/light mode functionality using material UI as mentioned in the following issue:https://github.com/FidalMathew/Poke-dex/issues/9

FidalMathew commented 1 year ago

@vaibhav-1508 Could you deploy the forked website using Vercel or other hosting platforms and share the link?

FidalMathew commented 1 year ago

@vaibhav-1508?

vaibhav-1508 commented 1 year ago

@vaibhav-1508?

sorry but vercel along with some of the GitHub functionality seems to be down for me at this time

FidalMathew commented 1 year ago

Ok @vaibhav-1508, could you send me a screenshot or video??

vaibhav-1508 commented 1 year ago

Here are the screenshots: image image

vaibhav-1508 commented 1 year ago

@FidalMathew is this fine?

FidalMathew commented 1 year ago

@vaibhav-1508 The navbar is not looking good with the design. Could you change the position of the switch below the search button? And apart from changing the background color. Could you also change the inner colors, and try out some combinations?

Let me know which you like, and then you can work on it

vaibhav-1508 commented 1 year ago

I removed the Navbar. I'm still learning react and I'm not yet proficient enough to implement the other features

vaibhav-1508 commented 1 year ago

image image @FidalMathew

vaibhav-1508 commented 1 year ago

@FidalMathew ?😅

FidalMathew commented 1 year ago

It looks off. Sorry @vaibhav-1508, I feel it would ruin the design if we add this to the website.😔

vaibhav-1508 commented 1 year ago

It looks off. Sorry @vaibhav-1508, I feel it would ruin the design if we add this to the website.😔

Okay, no problem 🚀

FidalMathew commented 1 year ago

Thank you for your efforts! 🚀