FidelusAleksander / ghcertified

Prepare for GitHub Certification exams!
https://ghcertified.com/
MIT License
433 stars 143 forks source link

Add <input /> to allow user to set number of questions #163

Closed tfsjohan closed 10 months ago

tfsjohan commented 10 months ago

PR Type

What's new?

Adds an element to allow the user to set the number of questions to include in practice round. Defaults to the number of available questions.

Related issue(s)

Closes: #144

Screenshots

image
FidelusAleksander commented 10 months ago

This is great @tfsjohan ! :rocket:

Let's remove the first line from the test card so the question count is not duplicated + bolded

tfsjohan commented 10 months ago

Done.

FidelusAleksander commented 10 months ago

Remove this bit aswell

.content .check-list li:first-child {
  font-weight: 600;
}

image

tfsjohan commented 10 months ago

Thanks! Happy to contribute! I'll use this myself a lot when practicing for Advanced Security.

FidelusAleksander commented 10 months ago

@tfsjohan I'm taking that exam on friday aswell! Good luck!

p.s thinking if i should enable discussions on this repository for people to ask questions/study together

tfsjohan commented 10 months ago

Yeah why not! I think that might be a good idea. I would for sure would have liked something like that before I took the first exam.

That's probably a better place for those kind of questions than using issues. And also it might be a good way to use what's asked about in the exam for real.

FidelusAleksander commented 10 months ago

Never really used GitHub Discussions too much, but i've set something up right now :) Talk to you there! @tfsjohan